Matan G

Results 4 issues of Matan G

Hi, It is not clear to me how to use the DIRT-T solver, The code has three `DIRTTSolver`: 1. https://github.com/domainadaptation/salad/blob/ba7abe162b87345b823209b5ef2ab8ee7d33602f/salad/solver/da/dirtt.py#L110 2. https://github.com/domainadaptation/salad/blob/ba7abe162b87345b823209b5ef2ab8ee7d33602f/salad/solver/da/dirtt.py#L148 (commented out, but uses KL which seems to...

question
docs

README.md says - "Model performance can't acheive that in the original paper." Can you please share what is the current performance you the model achieves? Thanks!

Currently, ONNX does not include the Cross op. PyTorch cross: https://pytorch.org/docs/stable/torch.html#torch.cross TF cross: https://www.tensorflow.org/api_docs/python/tf/linalg/cross

operator
enhancement

Is someone ever tries to build on MacOS, I had some OpenMP issues, I was able to solve these with: ``` brew install llvm --with-clang CC=/usr/local/opt/llvm/bin/clang CXX=/usr/local/opt/llvm/bin/clang++ LDFLAGS=-L/usr/local/opt/llvm/lib/ cmake -DBUILD_WITH_CUDA=OFF...