Matej Hrica

Results 14 comments of Matej Hrica

@slp I fixed it in the macOS implementation too. I don't know if it works, but it compiles with `cargo build --target aarch64-apple-darwin`.

Pipeline fails because of clippy issue fixed (separately) both in #148 and #149.

> > We are not doing anything special other than how the display is being handled, we are going to be use QEMU display support for this. > > This...

Yes, this doesn't seem to be correct. It is quite likely we shouldn't be enabling these flags even for the `passt` backend actually. The `virtio-net` device is based on firecracker...

@nirs > any thoughts on the API we want for enable offloading? I'd say I'd prefer more fine grained flags, and accept them as a bitmask argument. I'm not sure...

> mixing unrelated stuff (unix socket path and virtio feature flags), Yeah right the function name doesn't make sense at that point, so I should have picked a different name...

It seems it should, thank you for the report! This reminds me, we should try adding some static analyzer for the C code to the CI (`clang-tidy`?), maybe this could...

> Before I go and to the work though, I wanted to check whether safe GPU acceleration in VMs is even something other people want, too. Yes, this sounds interesting!...

>Vulkan would be the exposed API inside the VM (in addition to WebGPU of course), since I don't think many existing applications use WebGPU yet. Well even if they use...

Sure this could be nice, but could you clarify how would you like to use it? `libkrun` is currently a dynamically linked library and Rust doesn't have a stable ABI....