matsuji comments

Results 12 comments of


                                            matsuji

Skip DB execution when all ids for @OptionalParent are nil

Your comment is correct for many propertyWrappers, but not for `@OptionalParent`. With `OptionalParent`, even if the provided `models` by the `QueryBuilder` have several elements, the `set` passed to the query...

Skip DB execution when all ids for @OptionalParent are nil

I set `.some(nil)` for all objects when the database execution is skipped. Isn't that enough? https://github.com/mtj0928/fluent-kit/blob/021f7d59d970e524b4639f5844273cac1719455e/Sources/FluentKit/Properties/OptionalParent.swift#L178

Skip DB execution when all ids for @OptionalParent are nil

I checked the mentioned propertyWrappers, but none of them seem to be able to predict the results of the database execution. Therefore, I believe the current changes are sufficient. The...

Skip DB execution when all ids for @OptionalParent are nil

@gwynne Could you review this PR again?

Skip DB execution when all ids for @OptionalParent are nil

Thank you for reviewing the PR again. I investigated the unit tests for FluentKit and found that it already includes tests for `OptionalParent` here: https://github.com/vapor/fluent-kit/blob/bb47433520116b3cf7f3567137c81106b398b77e/Sources/FluentBenchmark/Tests/OptionalParentTests.swift#L7-L89 . The test covers both...

Skip DB execution when all ids for @OptionalParent are nil

@gwynne @0xTim The changes will help the performance of my app, thank you for responding to my PR!!

ログが役に立たない

誰かがやって、みんなで相談する info と debug を再検討する ## 手順 - [x] 全ログを消す ( @YoshikiHigo ) - [x] main に info をさす ( @YoshikiHigo ) - [x] その修正をみんなで議論する - [ ] debug を各クラスにさす

JDKのコンパイルレベルを選択できない

### コンパイル時のバージョンの指定問題があるかどうかは不明実装自体は難しくなさそうだが、優先度は下げておく ### 実行時のバージョンの指定新しいバージョンでkGPが動いていれば問題ない(ハズ)

研究系 issue の管理をどうするか

pending

一部のバグに対して再現性がない

Math 12でも発生