Mathilda Grace
Mathilda Grace
I would very much like this feature! I don't have capacity to work on this right now, but I can see where I would start... This function creates the commit...
@chrisccerami is this a feature you are interested in adding? Or is there a reason you would not want to add it. It seems like we could add this feature...
Sweet :) I will begin working on adding a photo size parameter to the API. @chrisccerami should I make a new issue for that?
You appear to be correct! I'm working on a fix for this now. It is interesting that NASA's documentation does not mention the "-BR" suffix: https://mars.nasa.gov/mer/gallery/edr_filename_key.html
A similar pattern can be observed with the Opportunity rover, but the default is the large (no suffix) version: https://mars.nasa.gov/msl-raw-images/proj/msl/redops/ods/surface/sol/01000/opgs/edr/fcam/FLB_486265257EDR_F0481570FHAZ00323M_.jpg https://mars.nasa.gov/msl-raw-images/proj/msl/redops/ods/surface/sol/01000/opgs/edr/fcam/FLB_486265257EDR_F0481570FHAZ00323M_-br.jpg https://mars.nasa.gov/msl-raw-images/proj/msl/redops/ods/surface/sol/01000/opgs/edr/fcam/FLB_486265257EDR_F0481570FHAZ00323M_-thm.jpg
@cuviper this is ready for review. I'm especially interested to hear your thoughts about whether NaN values should be recoverable using the formula sign * mantissa * 2^exponent.
Thanks for the feedback! --- > we can just say that the simple formula only works for zero/normal/infinite values (per classify()). I just pushed a change to update the doc...
I just added test cases for subnormals. The recovery code seems to work (within tolerance) for those, but I think they are being treated as zero.
Checkout https://github.com/mtilda/pid-rs/pull/2 to see how we might add a feature flag.
@atwRecsys > I found that running in Google collaboratory results in an error. I was able to reproduce the error with this code: ``` !pip uninstall -y numpy !pip install...