Máté Szabó comments

Results 43 comments of


                                            Máté Szabó

Replace wkdomains API in wikia.py

Hey, yeah, this API was removed during the 1.33 upgrade in 2020. We do not have a replacement at this point in time.

Reduce the incidence of infinite loops while case folding

I looked at https://github.com/google/re2j/pull/104 and it seems like the proper solution will be to generate this data on startup as noted in the comments there.

std::string facebook::memcache::thrift::McGatsReply::message' is private within this context

What version of mcrouter and fbthrift are you compiling? You may be trying to compile mcrouter with an incompatible fbthrift version.

Reduce the incidence of infinite loops while case folding

Thanks!

Fixed deb/tmp removal

@Godin this issue is preventing users from building the package on a fresh clone of the repository.

LRU Eviction Policy

Interesting! I assume this patch is to make it easier to use APCu as a general purpose in-memory cache. If so, we ended up having to optimize for that case...

LRU Eviction Policy

That's great, thank you!

Help needed with upgrading dependencies

@yurishkuro Thank you :) I think there are a few different things left: * `antd` can probably be updated to v4 now, hopefully it shouldn't be a large effort apart...

[Deps]: Upgrade redux-actions to 3.x

Yup that's right, I haven't touched redux or related deps in that work. If someone wants to have a go at this, I think it's possible—it shouldn't depend on the...

fbcode_builder should be synced to the mcrouter repo

I've noticed that the manifest I added in #2268 was missing some metadata required for mcrouter to be correctly recognized as a Meta first-party project. I've just submitted a PR...