Mark Sujew
Mark Sujew
@alvsan09 @martin-fleck-at Yeah, the changes look reasonable to me. Everything in regards to the select component still works as expected or even better 👍
@lucas-koehler It works for browser flawlessly now, but I'm getting another error on Electron (Windows 11) now: When closing the external webview window, I get an `Uncaught illegal access` error...
@lucas-koehler Interesting, it's 100% reproducible for me. It happens every time I open the webview in a secondary window 🤔
> Which node version `node -v` returns `16.16.0` for me > which electron version `15.5.7` which is referenced in our `yarn.lock` file.
@koegel @lucas-koehler I'm fine with that. Getting the bulk of the work in now and fixing anything that's not working in this version in a later PR sounds like a...
> Correct we if I'm wrong but I don't think a CQ for msgpackR is required You're right, as long as the 3PP license CI check succeeds, there shouldn't be...
> I did not get the UI for the validations yet, I thought the feature came straight from Monaco but I haven't been able to identify it, or it's potential...
@web-liuyang Can you give more context on when this exactly happens? I can't reproduce the behavior. The `Close All` command for example calls the `closeMany` method without the `options` parameter,...
@vince-fugnitto We would need a CQ for this as the code has been copied directly from vscode, right?
@vince-fugnitto I can do it, I just wanted to confirm :)