Mark Sammons
Mark Sammons
duplicate call for two supposedly different scores: https://github.com/CogComp/cogcomp-nlp/blob/master/similarity/src/main/java/edu/illinois/cs/cogcomp/wsim/wordnet/PathFinder.java#L163 presumably, supposed to consider both directions for the relationship by default (i.e. rel(w1, w2) and rel(w2, w1) which makes sense if the...
no indication that minio looked anywhere -- am I wrong? just an error about path it tried that did not work. Looks like there is now a disconnect between the...
It looks like if you call `addConstituent()` it sidesteps the span check: https://github.com/CogComp/cogcomp-nlp/blob/master/core-utilities/src/main/java/edu/illinois/cs/cogcomp/core/datastructures/textannotation/SpanLabelView.java#L62 This should perform a bounds check unless there is a good reason not to; otherwise, documentation should...
We have an explicit sentence view: make sure it is written out when serialized, and that it is read when deserialized. Remove TextAnnotation.sentences as Sentence data structure creates potential inconsistencies...
This constructor is not intended for use -- the version with ResourceManager must be used or the initialize step won't work. Error message is logged but no exception thrown: https://github.com/CogComp/cogcomp-nlp/blob/master/corpusreaders/src/main/java/edu/illinois/cs/cogcomp/nlp/corpusreaders/AnnotationReader.java#L35...
I'd like corpus readers to have a method to inform the user of the views they populate. One way to do this is to specify a [CorpusReaderConfigurator](https://github.com/CogComp/cogcomp-nlp/blob/master/corpusreaders/src/main/java/edu/illinois/cs/cogcomp/nlp/corpusreaders/CorpusReaderConfigurator.java) property/field name and...
https://github.com/CogComp/cogcomp-nlp/blob/master/core-utilities/src/main/java/edu/illinois/cs/cogcomp/core/utilities/JsonSerializer.java#L463 This method requires that strings contain only characters corresponding to tokens. For a transformed text, this means a version of that transformation must be maintained and used here, or...
test will fail with unexpected format error if TextAnnotation or other dependency changes.
…by specifying language-specific NER as prerequisite
The loop where this occurs: https://github.com/cttsai/illinois-cross-lingual-wikifier/blob/master/src/main/java/edu/illinois/cs/cogcomp/xlwikifier/postprocessing/SurfaceClustering.java#L170 appears to be incorrect. The size of the c1 and c2 surface form sets is determined by how many *different* surface forms there are;...