Manu Sridharan

Results 153 issues of Manu Sridharan

As a reviewer, I'd love to be able to comment on a paper discussion simply by replying to the notification email for someone else's comment. GitHub has this feature for...

enhancement

To reproduce, clone https://github.com/msridhar/obj-cons-autovalue-example and do: ``` git checkout a6a5384d3d29bc8cbe4c2a1da1223af0921850b6 ./gradlew --dry-run ``` I get the following output: ``` > Configure project : Unable to determine Checker Framework version. Assuming...

Example: https://github.com/msridhar/okbuck-ep-test/tree/autovalue Clone the repo and check out the `autovalue` branch. If you run `./gradlew :module:compileJava`, things run fine. But if you try to run `./gradlew :module:okbuck -Dokbuck.wrapper=true` you get...

See https://github.com/uber/NullAway/pull/636#issuecomment-1209930828 and https://github.com/uber/NullAway/pull/636#issuecomment-1210019289

Error Prone dropped support for Java 8 several months ago: https://github.com/google/error-prone/releases/tag/v2.11.0 Dropping Java 8 support will allow us to clean up several ugly hacks in the NullAway code and build...

longterm

If a constructor is annotated with `@Initializer`, NullAway currently treats the constructor as if it were an initializer method that runs after any constructor, which clearly doesn't make sense. Instead,...

good first issue

This would allow for more localized suppressions. Say we have a method `foo(Object o)` in an annotated third-party library where `o` has no type annotation, but `o` really should be...

enhancement
good first issue

Right now, our pre-commit hook to run GJF only works on JDK 11. After #572 our version of GJF no longer runs on Java 8. And, Google Java Format requires...

Once we land support for `@NullMarked`, it seems the AnnotatedPackages option would no longer be absolutely necessary. If we end up adding a flag for "JSpecify mode", we could say...

jspecify

According to the JSpecify spec, a `@Nullable` annotation should be acknowledged even if it appears in unannotated (unmarked) code. See [the spec](https://jspecify.dev/spec#augmented-type-of-a-type-usage-appearing-in-code) and also https://github.com/jspecify/jspecify/issues/235. This treatment corresponds roughly to...

jspecify