Vasyl Khrystyuk comments

Results 92 comments of


                                            Vasyl Khrystyuk

All Filter and Tag registration via interface

@bdw429s Adding ITag and IFilter abstraction is not hard. But It's hard to do something without a clear understanding of all the requirements(a lot of questions like "should be here...

All Filter and Tag registration via interface

I have reviewed this once again and had to admit - using this will cause a lot of code compatibility breaking and most important will create unnecessary interfaces in the...

All Filter and Tag registration via interface

This is a classical case described in this article: https://en.wikipedia.org/wiki/Composition_over_inheritance Also, when I add 2 interfaces and 3 classes, it affects only 5 logical elements. Adding an intermediate interface will...

All Filter and Tag registration via interface

Also, using interfaces with `ISomething` prefix is bad practice that came from C# world and is not welcomed in java.

XSS Protection

Seems to be that feature is analyzing the DOM tree of the HTML file and if the variable usage is unsafe - it escapes it automatically. This library has no...

`find_exp` Jekyll filter support

Also to review filters on: https://jekyllrb.com/docs/liquid/filters/ and add missing

`include_relative` tag support

Only jekyll flavour

Google login not working

I did so, but isn't working either. I have updated google play via apk and after I was able to login. But after that - blank screen. I believe bundled...

Retrofit 3.x Things

Return easy error api from Retrofit1.

Retrofit 3.x Things

Thanks. That's what I was asked for.