Sergey Bylokhov
Sergey Bylokhov
Looks like the problem is similar to the old one, the main method can be simplified: ```c int main(void) { cmsSetLogErrorHandler(LogErrorHandler); cmsHPROFILE mid = cmsOpenProfileFromFile(".../pycc2.icc", "r"); cmsReadTag(mid, cmsSigBToA0Tag); check(mid); cmsCloseProfile(mid);...
Probably it is better to check the data length for each sys message and discard it if the data is too small? Ignoring all possible AIOOBE from this large method...
> No, because determining the correct length of the message will require basically to parse it all, the correct length could be a 2 bytes or hundreds of bytes -...
Just curious about any performance benefits of this patch?
I still not sure about the case when we start to throw the "SkippedException" if the printer is not found and the "printer" keyword is set, especially for the manual...
Hello @alecl, thank you for your report, we are looking to this issue. I'll post a feedback when we will be able to reproduce it/
Hi, thank you for the bug report. Could you please check behavior of this problem using [jdk17](https://github.com/corretto/corretto-17/releases/tag/17.0.2.8.1)?
It would be good to understand how all that properties are handled by the skin. For example can you please check how the next property in the NimbusDefaults.java is handled...
Thank you for removing that large try/catch block. Looks much better.
The patch is mostly clean. The only change is a list of bugs in the [CheckCommonColors.java](https://github.com/openjdk/jdk8u-dev/pull/457/files#diff-6821cacbadd3e07fa935cb96b559dc2572e6ac749efe481740d54ccb6190f6f8R41) - the [JDK-8211999](https://bugs.openjdk.org/browse/JDK-8211999) is not present in jdk8u.