Morgan Roderick

Results 88 comments of Morgan Roderick

> Which steps are needed? 1. Change the name in package.json to `@sinonjs/nise` 1. `npm publish --access public` 1. Commit your changes 1. `git push origin master --follow-tags` (to ensure...

@betalb would you be up for contributing some documentation for these changes?

This needs a rebase to resolve the conflicts. @SimenB do you have time to take this across the finish line? If not, would you be ok with someone else doing...

> according to [the spec](https://fetch.spec.whatwg.org/#forbidden-header-name), setting/deleting a forbidden header should be a no-op That's the spec for `fetch`. This library does not deal with `fetch`. What is expected to happend...

That's an interesting one. Thank you for reporting it. I will take a closer look at this one soon 🤞

I think this issue can be closed now.

I've created #1654 with your tests to show the continued existence of this bug. Do you want to take a stab at fixing it?

I agree that it's unfortunate that `fakes`, `spies` and `stubs` behave differently, and that we should address this. Thank you for creating this issue to discuss it 🥇 > I...

@fatso83 do you agree with the bot closing this issue?