Mohammad Reza Kianifar comments

Results 10 comments of


                                            Mohammad Reza Kianifar

امرداد

@morilog جالبه، نمی‌دونستم و فکر کنم خیلی‌های دیگه هم ندونن ولی چیزی که عامه‌تره و اکثریت فکر می‌کنند درسته مرداد هست و وقتی کلمه‌ی امرداد رو توی سایت‌ها ببینین فکر...

add --grep option to parse logs stream output for match

Please accept this merge! It's really useful

add --grep option to parse logs stream output for match

Yes, now I get it works correctly for me too. Because kubetail stats from the end of the current log, I couldn't receive any log when I used ``| grep``...

Please add an option for disabling default tail

Yeah, your answer on grep PR was valid. About disabling tail, I saw there is a --tail option in your help menu, and because of that I thought it would...

Test data fetcher

hi @knjk04 Since the #63 issue is closed now, can I work on this issue?

Test data fetcher

Thank you @knjk04. Can you please describe the task a little more so I can start working on it?

push_notification: Use existing payload for 1:1 DM using DM group.

Should I merge this PR to https://github.com/zulip/zulip/pull/34822, which is for keeping the API compatibility in email notification for missed messages?

scheduled_messages: Set read_by_sender for self-DMs using DM group.

> I'm a bit confused about the state of this PR. I think it's waiting for mentor review? @alya Sorry, it was my mistake. I added the "maintainer review" tag...

notification: Use existing email format for missed 1:1 DM via DM group.

> You don't seem to handle anything here? Thanks for raising this. There was no test failure after my changes, so I thought it should be enough. Reviewing the section...

notification: Use existing email format for missed 1:1 DM via DM group.

@zulipbot add "maintainer review"