mrcaseb

Results 128 comments of mrcaseb

update: I was able to speed up my function in case anyone is interested ```r load_qs

Ah dang CRAN. Before you replied I found what readRDS is actually doing. It should be the below given code block https://github.com/microsoft/microsoft-r-open/blob/d72636113ede1c1d28959c8b8723c15c694957f4/source/src/main/serialize.c#L2236-L2282 I assume it's a CRAN exception for base...

The principle way `calculate_player_stats()` works is that we compute all stats on a per game base. And if the argument `weekly` is set to FALSE we summarise this per player...

OK I started updating this. I have removed irrelevant stuff and added a function that can be used to sum across columns using tidyselect variable delection to avoid crashes if...

Fumble stats refactored for season week distinction. Player position now joined via `load_players()` Still needs the option to summarise over all seasons and weeks similar to offensive stats

After I talked to @christianlohr9 I made the following changes: - exclude special teams plays and 2pt conversions (we might add them later) - create separate penalty data frame for...

- [ ] Function documentation needs update

@christianlohr9 and @TheMathNinja can you guys please review the output of this new function and look for possible bugs? Thanks!

> Well I guess we are making progress. Still strugglin' though. Not sure what `nflverse_sitrep()` is. > > > > ``` > > > idp21 > `summarise()` has grouped output...

I am considering pfr for this. We could write scrapers for their team stats tables and put it all together in pfr_scrapR. What do you think @tanho63 and @guga31bb? Some...