Vinnie Okada
Vinnie Okada
This addresses issues #153 and #250.
I realized that my first push had some changes in the wrong commit, so I rebased to fix that.
@DarwinAwardWinner good point about the potential confusion between `--exclude` and the new options. I pushed another commit that adds a new `--exclude-datasets` option to replace `--exclude`, and prints out a...
Oops, thanks for catching that typo @DarwinAwardWinner. I edited the last commit to fix that.
The problem with removing that entire block in `getsnapsfallback()` is that you won't double-escape the filesystem name, since `getsnaps()` doesn't pass in the already-escaped value. You could pass the escaped...
> the altered values are already being passed That's true for `$rhost`, but not `$fsescaped`. In `getsnaps()`, the escaped filesystem name is stored in `$fsescaped`. But `$fs` is passed to...
I'm not sure we want this in gitlab_git - I agree with @woita in https://github.com/gitlabhq/gitlabhq/pull/7417#issuecomment-50961245 that GitLab should dictate whether `--follow` is used. This PR would make it impossible to...
@bbodenmiller Yeah, I would probably vote to put it in GitLab instead of the gem. But since gitlabhq/gitlabhq#7417 does the same thing as this PR and always uses `--follow` when...