Michael Ponomarenko
Michael Ponomarenko
Nice! Thanks Ken!
I'll happily merge it - just a couple of things: (1) can you please squash the commits, and (2) commit --amend -s to add DCO? The first is something we...
/runtests
Thanks @lkollar . #3245 fixes those compilation warnings. I'll get that one in first, and this one can follow - hopefully while keeping `-Werror`
@lkollar - can you see if this builds for you now without errors while keeping `-Werror`? It builds for me with ``` /Users/mponomarenko/comdb2/src $ gcc -v Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1...
Let me take another stab at the m1 mac warnings. I do use that for development occasionally.
Ok - seeing the warnings you mentioned with a newer XCode. Going through them.
/runtests
Was the medal for the most failing test cases?
TODO: - Some deadlock potential when we run SQL from an SQL thread against ourselves - we should uncount our SQL thread at least. - Fix tests (systables changes break...