Milan Plžík
Milan Plžík
Hello; we use concourse to build a medium sized project and are seeing skipped PR checks. We did not manage to measure the impact of this, but it's definitely noticeable...
@itsdalmo note that this issue manifests quite often at our team, basically forcing us to re-trigger PR checks quite often (on daily to weekly basis) by empty commits/force pushes. There's...
It would be still nice to see whether there's any way to handle this in a more correct manner -- in a way, this workaround basically means that the data...
A small update -- looks like this issue has been triggered by custom metrics only.
Definitely not stale, just postponed until more important things get done.
This will be addressed in a follow-up PR that will cover the rest of #227 . Splitting the original PR made it a bit easier to rewrite and review.
This has been implemented for `apply` in https://github.com/grafana/tanka/pull/244 and https://github.com/grafana/tanka/pull/259; working this out for `diff` is still pending.
A simple experiment (sorting all objects instead of separating the ns/crds/...) showed that the object order actually doesn't seem to matter for diff -- even with CRDs at the top,...
OTOH, sorting the objects for UX purposes will still require more heavyweight refactoring, since the diff calculation works on two different sets of manifests.
Bump; it's been 3 years since filing this issue; any news?