Mikko Pesari

Results 10 issues of Mikko Pesari

I think `Domain::assert()` should ensure that `$input` is string. Consider this example: `Validator::key('name', Validator::domain())->assert(['name' => ['whoops']]);` ``` PHP Warning: explode() expects parameter 2 to be string, array given in .../vendor/respect/validation/library/Rules/Domain.php...

I have only used this library through another library, but here's a reproducible code: ``` $ composer require opis/closure ``` ```php

bug

https://psalm.dev/r/c2491c56ec

# Bug Report | Subject | Details | | :------------- | :---------------------------------------------------------------| | Rector version | 1.1.1 | `mb_ucfirst()` from `symfony/polyfill-php84` is not found by rector. I tried some ways...

bug

Implicitly nullable parameter types are deprecated in PHP 8.4 * https://wiki.php.net/rfc/deprecate-implicitly-nullable-types `?Type` syntax was added in PHP 7.1, so there are no backward compatibility issues. * https://wiki.php.net/rfc/nullable_types

Implicitly nullable function parameters are deprecated in PHP 8.4: * https://www.php.net/manual/en/migration84.deprecated.php#migration84.deprecated.core.implicitly-nullable-parameter The nullable `?Type` syntax was added in PHP 7.1, which is the lowest version supported by this library according...

### General * Fail phpunit tests on all issues (PHP warnings, deprecations etc.) ### PHP 8.4 * Run tests on PHP 8.4 * Fix deprecated use of implicitly nullable parameters...

`curl_close()` is noop since 8.0.0 and emites `E_DEPRECATED` since 8.5.0. It's used in `Monolog\Handler\Curl\Util::execute()` if `$closeAfterDone` = `true`. It's the same for `1.x`, `2.x` and `3.x`. On `3.x` we could...

Feature

`curl_close()` is noop since 8.0.0 and emits `E_DEPRECATED` since 8.5.0. This changes the code to call `curl_close()` only on PHP < 8.0.0. * https://www.php.net/curl_close * https://github.com/php/php-src/blob/php-8.0.0/UPGRADING#L1016-L1020 * https://github.com/php/php-src/blob/php-8.5.0/UPGRADING#L416-L418