Sara Itani

Ahh, makes sense. Thanks for pointing that out! I was wondering why variables were called out separately from expressions in general. For `instanceof`, I think I'm missing something because both...

Done! see #24. BTW, if you want to analyze the failures, the easiest way to do so is to open the `tests/output/drupal` folder using the syntax visualizer extension after running...

@cweagans I did not - thanks for the heads up. Currently it only tests *.php files - https://github.com/Microsoft/tolerant-php-parser/blob/master/tests/ParserFrameworkValidationTests.php#L27

@decanus sweet! A good place to start is any of the methods in `Node.php` or `Token.php`. Right now all the API tests are in [NodeApiTests.php](https://github.com/Microsoft/tolerant-php-parser/blob/master/tests/NodeApiTest.php), which get run as part...

Good catch. Honestly, based on the blame / commit history - it looks like a hack that inadvertently got committed from when I was working on completions support. So removing...

Cool idea! This would be super helpful for type inference. That said, one thing to keep in mind with any usability improvements is that we need to be really careful...

Also, of the two options you suggested, it seems that the multiple TokenKind constants is the only one that satisfies all the motivations. I can't think of many cases where...

Hey @cweagans, good question! I'm totally at liberty to discuss, but I don't know if I have a very good answer for you just yet. Like I said before, ultimately...

@nikic - yep, the idea is to completely get rid of the object representation, so in 32-bit mode, it would turn into two properties. And yes, it will most certainly...

@nikic darn... yeah, that's what I was worried about... that's worse than calling into a native extension. And just so I can fully wrap my head around this - why...