Mostafa Abdelwahab
Mostafa Abdelwahab
For whatever it's worth, I've made the code change in my fork (I have yet to add documentation and tests) https://github.com/mostafaCamel/pipeline/commit/0a3f5169e6c0f21a5a72dc3e6fc1a5b7f6dd7aa7
Thanks Vibhav! I am new to the project so let me know if I need to/can attend
Hi @vdemeester @waveywaves is there an ETA for the review?
> fyi ... when we implemented this in Shipwright, we used a different approach to access the value eliminating the need to load it but delegating this to Kubernetes. That...
Ah ok, I now understand. Thanks for the explanation!
Rebased the branch and added a new commit to address the reviews. - The reconciler will no longer unset param.Value after the first reconciler run I added an explanation in...
The eventual getter method I would need to implement (to get either the user-provided param.Value or the resolved-then-stored-somewhere value from the value source) will be used to replace every invocation...
### Proposed solution TLDR: A new boolean field `pipelineRun.Status.AttemptedValueSourceResolution` set to true during the first reconcile (along with querying the configmap and populating the value). I have a a poc...
Had a discussion with the maintainers in the Tekton working group meeting. I will look into how much work would be needed into refactoring the codebase/ implementing a getter method...
Apologies for the delay. I took a quick look at the feasibility of implementing a getter method for `PipelineRun.PipelineRunSpec.Params`. I think the mutating webhook can be the way to go...