Morten V. Pedersen
Morten V. Pedersen
@RoyiAvital Unfortunately not yet. We did not experience any problems related to this, but of course it would be great to fix. Would be happy to accept a pull-request. You...
We currently do not support header only use of the library (please use a new issue to raise additional questions - not relevant to the current issue)
Hi @svost looks good to me.
I guess it is enough to just define it? Does it need the empty value?
Simply defining it should make it work with #ifdef etc., are they doing something else with that marco (like checking it's value)?
Ok, just saw you wrote that the default value of 1 gives warnings. Where is that happening? In Thrift?
I just to get what kind of warning that produces.. since most code just checks whether it is defined e.g. with `#ifdef`
So this means that we are not the only ones defining it? Where is it being defined (besides by us)?
I see, in that case would the right solution not be to ensure that it isn't defined twice by guarding that `#define` with and `#ifndef`?
For example here BOOST should probably check whether that macro has already been defined: https://github.com/boostorg/config/blob/a9bc1346109c69bc2b5c7eb8251794c9278c7a31/include/boost/config/stdlib/libstdcpp3.hpp#L215 Because on older compilers they do not define it - but there it will cause...