Morgan Christiansson
Morgan Christiansson
I simplified the retry logic in a separate PR and rebased my changes on top of that. These changed can be viewed without the noise from removing retries here https://github.com/morganchristiansson/docker-ansible/pull/2/files
Also this PR uses github container registry for build cache. You may need to enable it to use it: https://docs.github.com/en/packages/working-with-a-github-packages-registry/enabling-improved-container-support-with-the-container-registry There's also a docker registry that works largely the same...
Failed on ```make login USERNAME=${{ secrets.DOCKERHUB_USERNAME }} PASSWORD=${{ secrets.DOCKERHUB_PASSWORD }}``` It's using same secrets as before.. The same branch is building fine with GH actions in my fork https://github.com/morganchristiansson/docker-ansible/pull/2 Btw...
Oh it will try to push the tags in my docker hub... docker buildx build --push is used.. Can remove `docker buildx build --push` flag.. ~~Some newer image builders write...
I removed the --push it should use buildcache and for the builder image `IMAGE_CACHE = ghcr.io/$(GITHUB_ACTOR)/docker-ansible`. Which **needs to be enabled** https://docs.github.com/en/packages/working-with-a-github-packages-registry/enabling-improved-container-support-with-the-container-registry (it said the old github docker registry way...
Please enable github container registry in feature previews per my link above and re-run the actions. I've prepared the PR to use warm build cache from ghcr.io/morganchristiansson/docker-ansible (which is also...
The PR looks much better! Can actually read thru it now :+1: The GH actions should have worked then... per the docs for gh container registry and buildx build I'm...
It will take a while for actions to run. This PR will be the 365 checks at the back of the queue if my warm cache works it should run...
I missed enabling buildcache from ghcr.io/morganchristiansson on builder image, which felt like one of the slowest images to build and it runs in every action so thought it'd be worth...
After almost a whole day all builds have finished.. I managed to exclude kops 1.18 and earlier from arm64 so got no failures in build-kops now. (I left comment above/inline)