Moreno Carullo

Results 11 comments of Moreno Carullo

@mbackermann I am now working on a dedicated PR for that

I understand that Devise relies heavily on warden etc which rely on sessions, or a fake version of it at least. Thus, we've circumvented this by creating this concern/module that...

@arpu you need to drop that module I wrote in my earlier comment and include it in the SessionControllers. If @carlosantoniodasilva or other maintainer can suggest their acceptance, I can...

@connortorrell you can use the solution posted here. I'm waiting for maintainers to say they'll accept the PR -- before it stays there forever

@NfoCipher I was waiting for an OK here to create the PR. BUT, since I got no answer ... I'll create the PR so that at least people can have...

FYI, I am preparing a PR for this issue. To begin with, we'll have a fork with the fix applied which is slightly better than the module-drop-in there, but I...

PR is here: https://github.com/heartcombo/devise/pull/5474 Feel free to use the referenced branch/fork while we wait for it to be merged.

Hey @carlosantoniodasilva , this is a first part of the work to allow API mode to work as well. See https://github.com/heartcombo/devise/issues/5443.

> Why the hard lock to Rails 7+ ? The PR looks like it will work with Rails 6 without a hitch. you are right: but in Rails 6 it...

> I think this is a good hack as bandaid. but I don't think this is a good solution. Some users may be using it in API mode and with...