Chris Kruger

Results 14 comments of Chris Kruger

Apologies for the confusing wording. I will try again to explain what I mean. The problem as I have observed is that in apps that have been _upgraded_ to 5.2...

Note that load_defaults was only added from rails 5 onward. https://guides.rubyonrails.org/configuring.html#results-of-config-load-defaults

doesn't my change just work for all cases? or am I missing something? if `config.action_controller.default_protect_from_forgery` is nil as what might expect in an upgraded app, it will not match and...

> It will be `nil` from Brakeman's point of view in both a fresh and upgraded app, because there is no code that Brakeman sees that sets the value. What...

Nice! Do you need me to do anything?

I tried the renaming. It doesn't make a difference.

This has snookered me too. I've worked around it for now by using ``` response.body(false) ``` on the promise argument to get raw body.

We are seeing this as well. ``` < var s = []; < return b(this.text(t), n.term, s, i), s.join(""); --- > var o = []; > return _(this.text(t), n.term, o,...