Dan Coldrick

Results 16 comments of Dan Coldrick

> @tballison @monkmachine > > > Or do you want to use our current parser only if the dwg executable is not available. > > I would vote +1 on...

> should we use TestContainers to test this within a docker container to make sure it works? or is it sufficient to just run test only if dwgread is installed?...

@nddipiazza @tballison This looks messy, can you advise a way to clean it up? A better way of doing it? Still think its worth having the comments there? https://github.com/apache/tika/blob/28ceff420948ede5e18ba10a4f1d6d1751f30b3b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-cad-module/src/main/java/org/apache/tika/parser/dwg/DWGReadParser.java#L272-L318

> > > > @nddipiazza @tballison This looks messy, can you advise a way to clean it up? A better way of doing it? Still think its worth having the...

Help! @tballison @nddipiazza Any reason why this section would sometimes write extra lines out? On some json files when cleaning up it writes out the file correctly then appends another...

If I read byte by byte (i.e. byte[] bytes = new byte[1];) I get the correct result: ![image](https://user-images.githubusercontent.com/36521886/169118333-e9a5509e-8fb4-4b28-9be4-6d326a03059a.png) If I read with anything other than byte by byte I get...

If I use buffer reader I get the correct output but it's slower: 3s vs 10s (it's quite a large file) ``` public void jsonConvert() throws FileNotFoundException, IOException { //FileInputStream...

> No, that probably won't work. Sorry. If you send me some examples, I can try some things. Yeah we'd be ok if Jackson allowed "nan" as well as "NaN"...

> Can you tell if they're writing utf8? Are there any ascii accented data items or non-ascii characters that you can use to figure out what they're default encoding is?...

> Can you guarantee that reading per line will be ok on this json-disaster? If so, that's the way to go. > > The other thing is that you'll want...