Pablo Montalvo
Pablo Montalvo
Finishing up draft, removing this validation functionality from #28711
Main concern I had was using `inspect`, so I moved it to the test suite instead of the actual validation function. That way we don't inspect at runtime, we just...
Hi @Rocketknight1, very nice! FYI, I'm working on standardizing the processors here https://github.com/huggingface/transformers/pull/30511 and I was thinking how to make this compatible with apply_chat_template - thought you might want to...
I don't think you need to pause yours! I'll try and get mine merged soon - it's already approved, just need to make sure nothing breaks
Alright, should be a bit better! I added some more typing for audio inputs to protect them a bit more. Worked on a test to enforce this structure as well,...
Agree with you @ArthurZucker - I'll update the PR to have that, looks super nice
Also linked to #28711 as I discovered logic flow issues here, seems fitting to abstract them separately and deal with the actual processing in the main PR. Here I'll try...
@amyeroberts I think it's ok to take another look at this one now! Improved a few things, didn't add much, will rebase the other refactor off of that one
Nice -will review this afternoon!
Thanks @RUFFY-369 ! Reviewing this afternoon :hugs: