Moisés

Results 27 comments of Moisés

I have read the CLA Document and I hereby sign the CLA

I would like to share that I successfully test that we could include 100 addresses in one request to `coingecko`.

I think that we should know first if the token address is in coingecko or not to avoid requesting tokens that aren't going to receive price response.

@Uxio0 I can add balancer to ComposedOracle would be interesting?

@rafaeltorres-seegno had you an opportunity to see this? https://github.com/safe-global/safe-deployments/pull/129#pullrequestreview-1142646676

Maybe is related with the contract version, we are currently working adding support for 1.4.1 version https://github.com/safe-global/safe-transaction-service/issues/1433

We should decide what library we are going to use https://www.rabbitmq.com/devtools.html#python-dev I think the more used is pika. @Uxio0 works for you?

I'm thinking about the strategy of reconnection if the channel is closed or if the connection is closed with `RabbitMq`. As we know the idea is to keep one instance...

> Did you check if there's a connection manager? For example for node.js and amqplib there's https://www.npmjs.com/package/amqp-connection-manager Yes I didn't find anything similar that manage the connection by itself, I'm...

> > Yes I didn't find anything similar that manage the connection by itself, I'm taking a look to `geventconnection` of Pika, that allow to configure callbacks to some events...