Mohit Mohit
Mohit Mohit
Hi, I compiled following C++ code in linux machine using `g++ -c code.cpp -o code.o` ```C++ #include using namespace std; int main() { cout
Steps to reproduce this issue in macOS. 1. Create `/tmp/new_root` 2. Copy paste required stuff from "/bin" to "/tmp/new_root/bin" and "/usr/lib" to "/tmp/new_root/usr/lib". 3. "chroot /tmp/new_root".. It will work fine....
Please review and merge this pull request : https://github.com/random-basad/json11/commit/7a03087db4898e50d41d06e1fd7945c92a109bd4 Thanks. @artwyman ```In file included from /home/genstor/toolchain/json11-master/json/json11.cpp:22:0: /home/genstor/toolchain/json11-master/json/json11.hpp:228:25: error: 'virtual const json11::Json& json11::JsonValue::operator[](const string&) const' was hidden [-Werror=overloaded-virtual] virtual const Json...
1. iterator's logic is a bit tricky. Make sure it is described well and it has enough tests. 2. Make sure that iterator is not missing any member required for...
1. Make sure all the unit tests of std::unordered_map, with lazy_map like interface are passing for lazy_map as well. 2. We need to exclude the tests which depends on unordered_map...
README file should include: 1. Sufficient examples. Covering all the methods of lazy_map and all states in the lifetime of lazy_map. 2. _O(1)_ claims should be said as "almost O(1)"...
1. Clients of lazy_map should be able to use custom underlying map instead of std::unordered_map. It should be passed via template arguments. Same for std::unordered_set. 2. Default constructor of lazy_map...
### Comment from reddit Implementation of at would be more efficient if you got rid of the first call to contains_key and simply used find directly. You call contains_key to...