Mohammad Fawaz

Results 151 comments of Mohammad Fawaz

It looks like the type `ContractCall` doesn't have access to the methods of `SomeAbi`. E.g.: ```rust script; abi SomeAbi { fn foo() -> u64; } fn main() { let caller:...

I have a fix (https://github.com/FuelLabs/sway/compare/mohammadfawaz/1261?expand=1) for the simple reproducer above but not for the full problem. There are some remaining complications with the type engine for `ContractCaller`.

Basically, returning a `ContractCaller` from a function and trying to call contract methods on the result still doesn't work.

This is nearly done but needs some tests. For now, the SDK team can experiment with the `JSON` file generated - there should be no blockers. The old `JSON` file...

Need to fix something related to the (in)stable ordering of the output. Turning into a draft temporarily.

> @mohammadfawaz On the examples, we created, `typeArguments` was an object which looked cleaner by just having the `typeArguments: [4, 5]`. > > What are the motivations for having the...

> In a future PR, let's make sure to write a blurb for the book documenting the new design of the ABI. 100%. I will start by adding the new...

It is possible that the `assert` here is completely wrong. We should check the math again... `str[4]` and `str[8]` should require the same number of slots so there is no...

From @SwayStar123's desription in https://github.com/FuelLabs/sway/issues/2433: > Heres some nominations for addition to the prelude > * Address > * ContractId > * Identity > * transfer() > * msg_sender() >...

> Personally, I dislike magical global functions in general Agree 100%. If we implement the following proposal https://github.com/FuelLabs/sway/issues/2463, then a lot of these functions become methods and they will be...