mofeiZ
mofeiZ
@acdlite @gnoff @sebmarkbage Thanks for all the feedback so far! All suggested changes have been made, and I'd love to get some feedback on this again 🙂
Thanks @sebmarkbage @gnoff, I really appreciate all the feedback you've given - I definitely learned a lot writing this PR! Sorry for the long wait (I wanted to confirm that...
Also had a question about https://github.com/facebook/react/pull/25437#discussion_r1018398657 > I think going forward our suggestion for rendering React only to part of the tree will be an API that treats and existing...
@gnoff @sebmarkbage ping for review 🙂
(Sorry for the back and forth, and thanks again for the review! Once again putting this back on your queue @gnoff )
(Sorry for the back and forth, and thanks again for the review! Once again putting this back on your queue @gnoff )
Yess the new output looks so good!
Discussed offline with @josephsavona and @mvitousek. I'm temporarily closing this PR as it requires non-trivial changes to how we currently model effects.
Thanks for the summary! We've been evolving compiler flags as we try to optimize for perf internally. One recently added option [`Environment::moduleTypeProvider`](https://github.com/facebook/react/blob/main/compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts#L151-L155) looks closer to what you need. This would...
Closing as this is a duplicate of #31199