Mohamed Elasmar
Mohamed Elasmar
@bryantbiggs .. Could you please check this PR.
Thanks @antonbabenko for your quick response. Regarding the Readme update, is it ok to add a new section regarding SAM CLI integration before the [FAQ section](https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/39e45b65e2c421f5932e5456c3ab4897dc0ee0da/README.md#faq) in this Readme file
> @moelasmar I would put it under the [`How to deploy and manage Lambda functions`](https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/master/README.md#-how-to-deploy-and-manage-lambda-functions) I founded that it is better to have a separate section for SAM CLI integration,...
Thanks @antonbabenko for your comment. Let me think more about it, also we can discuss it more in the meeting we have next week.
The issue is mainly we add the policy "arn:aws:iam::aws:policy/AWSXrayWriteOnlyAccess" regardless if the value of "Fn::If" evaluation result. We should add this policy only if Tracing is enabled.
PR got merged
Thanks @Rondineli for your contribution. I just have a concern about the customer experience of the new property `RequestValidators`. My issue is if the customer enables the validations in the...
Thanks @Macok for your contribution. I updated your branch with the latest changes from the develop branch. We need to ask our security team feedback about this change. We will...
Thanks @WinterYukky for your effort. I have some concern about the solution you suggested to fix this problem. My concern is it could not be extend to other IaC frameworks....
Sorry @WinterYukky for my slow reply. I want to leave the `ResourceMetadataNormalizer.get_resource_id` for now as in my opinion we should fix it from the CDK side, we need to push...