Michael Blonsky
Thanks for including documentation on using VS Code on HPC. I have a method for attaching a python debug process that others may find useful. Feel free to add this...
Addresses #100, #102 - [x] Reference the issue your PR is fixing - [x] Assign at least 1 reviewer for your PR - [x] Test with run_dwelling.py or other script...
Build/packaging updates before the next release: - [x] Use pyproject.toml - [x] Check `defaults` data folder location/best practices - [x] Add python and package dependencies, see #100
Long term goal to use Pydantic for input data validation. Could be used for a few things: - [ ] Dwelling/equipment arguments: - [ ] Data types - [ ]...
The equipment schedules have 1 extra row to prevent a StopIteration error, see: https://github.com/NREL/OCHRE/blob/79fd6ad9d3251347886bb91e88f7ce44fc00e376/ochre/Simulator.py#L180 The schedule index should align with the Simulator.sim_times. That'll make it easier for users to revise...
It would be great to natively use PySAM's battery model. It should include all of the same features as our model, plus more. A few things to verify that it...
There is no way to update the house voltage when co-optimizing. (Co-optimization is iterating within a single time step, which can be done with `Simulator.update_model`.) Voltage can only be updated...
Just tried running SAM v4.0 within OCHRE and it failed: ``` pvsamv1 simulation error : precheck input: variable 'subarray1_rear_soiling_loss' (Sub-array 1 rear soiling loss) required but not assigned ``` reset...
When file paths are not absolute, we currently look for the file in the `OCHRE/defaults` folder, which isn't always useful. It's probably best to assume the user specifies a relative...
When running at 1 minute timesteps, the thermostat control with deadband can exceed the deadband limits. It's mainly an issue for the water heater, which can increase in temperature pretty...