Mitch Naylor
Mitch Naylor
Sorry for the initial test failures! It should be taken care of now. Also I wanted to point out that I did not have access to a GPU while developing...
Thank you @younesbelkada! It is ready for review now 😄
Hi @younesbelkada / @ArthurZucker - just checking in to see if there is anything you need from me before reviewing this pull request. Looking forward to being able to use...
Thanks @ArthurZucker, and no worries! 😄
Thanks for the review @ArthurZucker! I'll reply to individual comments where I can clear things up, and I'll accept your suggestions wherever I can. I'll probably be able to start...
Alright @ArthurZucker this should be good to review again! The biggest updates in this version are removing the `reset_parameters` methods in favor of `_init_weights`, renaming variables/comments to avoid single-letter names,...
Hi there @ArthurZucker - thanks again for the feedback in your previous review. Just reaching out to see if anything else is needed before reviewing and hopefully merging!
Thanks @ArthurZucker! I appreciate the quick review and the encouragement 😄 I added a couple of questions where things weren't totally clear to me, but I can get started on...
Alright @ArthurZucker, I think that's everything except the threads with ongoing discussion. I'm super happy with how this is shaping up! In the latest batch of commits: * Renamed classes,...
@ArthurZucker as an update, it looks like the fix for left-padding is going to be a more significant effort to implement -- the relative bias is applied in the attention...