mokhtar

Results 84 comments of mokhtar

There is a nice library that I use in my own projects, [node-nat-upnp](https://github.com/indutny/node-nat-upnp) but it needs a couple of small [fixes](https://github.com/indutny/node-nat-upnp/pulls)

Watch out there is a small bug in node-nat-upnp I made an attempt to solve it at one point in https://github.com/indutny/node-nat-upnp/pull/20 which was good enough for a use case I...

I have an almost identical config, and seeing the exact same problem, when I have a module that is npm linked.

@artm I removed `"react-hot-loader/babel"` from the `plugins` array in the `.compilerc` and the problem went away. Can you confirm that this would solve your problem too?

I submitted a PR in electron-compilers which is one possible fix for this issue. https://github.com/electron/electron-compilers/pull/73/commits/a4cc09893a03ec50f1c61dd3450eaa66a7628f1d

Replaced by https://github.com/Joystream/joystream/pull/4213

Implemented in https://github.com/Joystream/joystream/pull/4199

> How to test in QA: verify that validator does not receive any tx inclusion fee revenue at all, they still should be able to receive tips. I added a...

I tested alternative approach using additional `SignedExtension` to validate transactions that make a call to the `bond()` dispatchable in https://github.com/Joystream/joystream/pull/4213 Tested manually and works as expected. Since a node will...

> Does this mean this check is not part of consensus? if so then I don't think this really works, a motivated attacker could still produce a valid block which...