hyelynkim

Results 8 comments of hyelynkim

@seunghoh > I have some questions about the props and component naming. > > * Popup component already renders in a FloatingLayer. FloatingPopup sounds confusing to me. What do you...

> Please check the console error to fix the prop bleeding in sampler. Fixed.

> @mmyelyn, Please check console warning in qa-virtualgridlist sample. Also, scrolling doesn't seem to work in this sample. Fixed console warning and scrolling in qa-virtualgridlist. and also i found a...

@juwonjeong Sorry, It's fixed. Also, I was managing the value twice using useState, but I deleted it as it seemed unnecessary. In the process, I found missing cases and added...

@MikyungKim Ok, All reviews have been reflected. Also, I accidentally commit the package-lock file, so I removed it.

> Let's change the sample name. The sample name and other reviews have all been applied.

> @mmyelyn, font scale does not work with http://SERVERIP:8080/?path=/story/about-a-tour-of-sampler--a-tour-of-sampler&globals=font+scale:1.6. Could you please check it? This is because fontScale was not passed when updating the base font in init. In the...

@MikyungKim I changed to handle resizeObserver instead of calling resize handler. but, When observing `this.clientSiblingRef`, the size of the contextual button does not change, so I added document.body is observed....