Manuel Mendez

Results 135 comments of Manuel Mendez

Just a random gh-stargazer of the project but if you want chat and not slack, but find publicly searchable/readable logs important then zulip is a really great option: https://blog.zulip.com/2022/05/05/public-access-option/. side...

> > zulip is a really great option: [blog.zulip.com/2022/05/05/public-access-option](https://blog.zulip.com/2022/05/05/public-access-option/). > > Oh that's nice! Keep in mind that literally happened 5 days ago, even my last reply was before that....

@moul any pointers on this, this is biting my quite badly (but for `User:` config), I'd take a stab at fixing this.

`path/filepath` -> `path` same deal, `path` -> `encoding/json` does the right thing... ```ShellSession [17:08:52]-[~/cloned/mvdan.cc/gofumpt]─[manny@zennix]> cat gofumpt_does_not_like_path_filepath package tests_test import ( "path" "time" "github.com/tinkerbell/tink/pkg/apis/core/v1alpha1" "k8s.io/apimachinery/pkg/types" "sigs.k8s.io/yaml" ) [17:08:54]-[~/cloned/mvdan.cc/gofumpt]─[manny@zennix]> ./gofumpt -d gofumpt_does_not_like_path_filepath...

@mvdan not quite. gofumpt is creating 3 import groups instead of just 2. I was expecting ```diff import ( "path" "time" + "github.com/tinkerbell/tink/pkg/apis/core/v1alpha1" "k8s.io/apimachinery/pkg/types" "sigs.k8s.io/yaml" ) ``` And it does...

yeah when I went trawling for an easy fix I noticed the same and thus brought the issue up instead of opening a PR :)

good news for me then! Yeah I saw the HCL issue. I can't really think of a way around have a messyish (to whom though) config. I've only interacted with...

Not sure if adding PubkeyAuthentication to all ssh clients is ok or if I need to do something special for solaris or other oses. Also I'm expecting tests to fail...

ping @mitchellh @briancain @chrisroberts (according to git-blame&git-log)

@nihilus I don't see how telling shellcheck to use dash helps here. dash does not support the feature I'm looking to use in ash. ``` [manny@manny ~]$ shellcheck -