Marcus

* Introduced private functions safeTokenTransferFrom and safeTokenTransfer * Fixes #14 * Moved private functions to the end of the file as suggested by solhint

Add indexed keyword in events

6

On which parameters? What is the use case for this? How much more expensive will the events be?

- Init a truffle project directory - Add a README.MD for developers - Add initial support for at least testRPC, maybe ganache

When calling functions in other contracts we make assumptions about what happens there, e.g. with our calls: Token(token).transfer(msg.sender, amount) Token(token).transferFrom(msg.sender, this, amount) We should check after these calls, if what...

With the added ECR223 compatibility we need test cases for the following: - Use approve and depositToken to deposit an ECR223 token into the FD contract. Expected: Updated user token...

Gracefully handle missing token contract functions that are optional

2

Backend assumes that fuctions like decimals are always implemented in token contracts. This is not the case and some functions are optional per: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-20.md We should handle all contract calls...

Currently freeatnet sorts this out manually (after a downtime) by running the script: https://github.com/forkdelta/backend-replacement/blob/master/app/src/contract_events_backfill.py This should either be done automatically or freeatnet suggested: "I would implement periodic orderbook refreshes, on...