Michele Mancioppi

Results 69 comments of Michele Mancioppi

There's discussion on https://github.com/open-telemetry/opentelemetry-java/pull/4574#issuecomment-1213233736 whether the ARNs like the one this PR builds are actually correct. Until we are use, let's not merge :D

**Update:** The uncertainty about ARNs seems sorted out

> Looks like there may be slight differences between fargate and ec2 metadata response. As a sanity check can we add those example responses linked in the comment above to...

@Aneurysm9 about the duplication of Log Group|Stream Name|ARN attributes, I implemented the spec: https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/cloud_provider/aws/logs/ . They may be duplicative (provided that the backend behind does processing, which is not the...

> All of the log group/stream fields are optional. There is no requirement to include all of them if any of them are included. IMO, this would wreak havoc with...

@willarmiros #4574 does not implement `AWS_ECS_LAUNCHTYPE` but for the rest yes, it is a superset and I'd be OK closing mine as duplicate

@felixscheinost i missed out on this PR and worked on #4670. Your PR is effectively a superset of mine, with the exception of `AWS_ECS_LAUNCHTYPE` and `AWS_LOGS_STREAM_ARNS` and a couple small...

> @mmanciop Thanks for rebasing your changes on my PR! > > Regarding the change in the log group ARN. That dosn't seem right to me. Have you tested this...

> @mmanciop When I do `describe-log-groups` on my log groups I get an ARN without `/aws`. > > Only when the log group name contains `/aws`, like for lambdas, does...

So, what I see in the ECS console when deploying a simple CDK + Amazon ECS project is this: ``` awslogs-group | /aws/batch/job -- | -- awslogs-region | eu-central-1 awslogs-stream-prefix...