Michael Kuhn

Results 8 comments of Michael Kuhn

Thanks for taking this over! I've long forgotten for which project I needed this :) Looking at the code in #86, the problems addressed by this PR would still be...

I have added a pull request (#58) that adds a parameter for the NA color. If you have a full row or column of NAs, the clustering function might not...

No worries! I could go ahead with my own fork for now. > * The names `taxid2name`/`taxid2names` and `name`/`names` are a bit too similar, and I feel that users will...

Ah, I thought that `taxid2name` was considered internal and not part of an API. I would also avoid breaking changes. I find the code example a bit confusing. As a...

I've been writing too much R recently, which rots your brain: a single item in Python is of course not the same as a single-item list, unlike in R. So...

No worries! The other day I got a question on a PR from eight years ago, I had to jog my memory quite a bit on that one. Which comment...

ok, I've addressed the comments in the "conversations" dropdown, hope everything is fine now!

Ah, I see! I can't remember this change, but it's more consistent to have it outside the `with` statement. I've now put the `if` statement outside the `with` block. I...