Juyeong Maing

Results 8 comments of Juyeong Maing

Maybe most use cases related to this subject are for data migration. See https://github.com/prisma/prisma/issues/11194, https://github.com/prisma/prisma/issues/15384 as well :) Are there any use cases which are not for data migration? (just...

I think It may help #189, #179 as well

> @mjy9088 pls be aware that your code returns error type for Product and SoftwareApplication merge: > > ```typescript > type Error = MergeSchema; // "Error: Leaf types expected." &...

I’m strongly in favor of exporting the leaf types. In fact, I’m already using them in my own codebase — for example: ```ts import { Thing } from "schema-dts"; export...

I didn’t realize there was a related issue, but after reading it, I think trying to cover all similar cases would be never-ending. I don’t think #61 is necessary now....

~~I misread something and closed it by mistake~~

> @mjy9088 this is the PR I'm interested in. I like the idea of passing options to the `create` function to address the unintuitive part. Oh sorry I misread someting....

I just got home and committed it! I wrote the explanation for `visible` on my own, so please check if it’s correct.