Michael Wall
Michael Wall
So this gets a list of the table IDs (tableIDsBefore) before scanning the metadata table and then gets a list of the table IDs afterwards (tableIDsAfter. While scanning the metadata,...
> @mjwall I pulled these changes locally and experimented with writing the following unit test and it passed. > > ```java > @Test > public void testMissingTableIds() throws Exception {...
> @mjwall thinking about unit testing the cases where table ids changes during scanning the refs. Maybe we could simulate this by making TestGCE.getReferenceIterator() change the tableid set. I considered...
> > I am worried my assumptions are wrong here, but assuming they are correct the logic in ensureAllTablesChecked is this. > > The logic in ensureAllTablesChecked looks great and...
> I think you are on the right track but I just had a thought. If we only care about the split points maybe it would be better to check...
> > I considered adding some functions to TestGCE but then pulled out the logic to one method. I was hoping it would be enough to just test that method...
> > But thinking about it further, I realize you might be getting at this. For whatever reason, something unexpected happened during our scan of the metadata table. Therefore, we...
I think this is ready to go. @keith-turner do you want one more pass? Thanks to everyone who has provided feedback.
@ctubbsii you still want to review this?
> > @ctubbsii you still want to review this? > > Yes, I would like to. I'd also like to get any changes merged into the current development branch, so...