mjp98

Results 7 comments of mjp98

The use case that brought me here was to pass an interface test that would like two fitted objects to be equal when one is updated with unchanged parameters. I...

Thanks for the reference! @willtebbutt It's not clear to me that testing inequality at the interface level well is feasible. This must be a standard issue, perhaps typically dealt with...

I'm hesitant about `Matern12Kernel() == MaternKernel(nu=0.5)`, since this would introduce cases where `K1 == K2` but `K1(x,y) !== K2(x,y)` due to numerical error, e.g. ``` julia> K1 = KernelFunctions.Matern12Kernel() Exponential...

A clear definition is definitely sensible to avoid ending up in a hole. There do seem to be various edge cases, as I don't think points 1. and 2. above...

Okay, so we could have: > k1 and k2 are necessarily unequal if they are instances of different (mutable) structs. > If k1 and k2 have the same struct, they...

I have almost got tests passing locally on the addition to `test_interface` of ``` # Check that two instances of the same kernel are equal @test k == deepcopy(k) @test...

This seems to be three separate issues: 1. no methods cover all `BlockDiagonal(::Vector{