Myung-jong Kim
Myung-jong Kim
@forgedhallpass @Mzack9999 please review :)
> The same comment as in the other PR. Please remove the `join_slice` from this PR and then we can merge it. > > [#2372 (comment)](https://github.com/projectdiscovery/nuclei/pull/2372#discussion_r961666373) Hi @forgedhallpass, thanks for...
Changes in this PR is included in https://github.com/projectdiscovery/nuclei/pull/2372
@ehsandeep, if this issue is open, please assign it to me. I will take a look :)
Tasks: - [x] `sort(list)`: https://github.com/projectdiscovery/nuclei/pull/2372 - [x] `uniq(list)`: https://github.com/projectdiscovery/nuclei/pull/2372 - [x] `sort(string)` : https://github.com/projectdiscovery/nuclei/pull/2372 - [x] `uniq(string)`: https://github.com/projectdiscovery/nuclei/pull/2372
@ehsandeep @Mzack9999 @forgedhallpass I have a question related to this issue. Can the helper functions have return types other than string? While working on this, I thought that I could...
PR for `uniq()` created: https://github.com/projectdiscovery/nuclei/pull/2498
@forgedhallpass please review :) It seems like build test is failing for reasons unrelated to this PR. Let me know if I am mistaken. ``` [ERR] Could not initialize interactsh...
Hi @Mzack9999 @forgedhallpass Thanks for the advice. I updated the PR so that `sort()` for list returns a string or a slice depending on the number of args. It seems...
@forgedhallpass thanks for the tip. However, I cannot use `join()` because it accepts a variable number of string parameters, whereas `sort()` returns 1 slice of string. Instead, I created another...