Marcel Jacobse
Marcel Jacobse
Sorry for the work I caused with my suggestion :smile: I also think the explicit conversions are a good improvement. I am not quite clear on how these changes relate...
Sure, here is the PR: https://github.com/Reference-LAPACK/lapack/pull/706 The CBLAS (and probably also LAPACKE) stuff will need more work I'm afraid. On a first glance it seems like the recent `BLAS_FORTRAN_STRLEN_END` addition...
As pointed out in https://github.com/catchorg/Catch2/issues/2238#issuecomment-1261152406, the removal of trailing zeros in `fpToString` would cause trailing zeros in the exponent to be cut off. So as suggested there, this part should...
I think it would be reasonable to require a Metis header to be available and otherwise error out of the compilation. So basically get rid of `SPRAL_HAVE_METIS_H` and the default...
I'd appreciate that too, working with large matrices is pretty impractical in the current state. And to a user it might not be immediately obvious that they are waiting because...
The example in the documentation is just a reference to the actual example file, so it should always be the relevant, up-to-date version: https://github.com/ralna/spral/blob/58f8a4aca41f427df0b56f19d5c21a2121c4f610/doc/C/ssids.rst?plain=1#L764 However, it looks like it does...
> use `-lc++` when clang is being used (clang is never a symlink to gcc), otherwise use `-lstdc++` for gcc. I'm not sure this is ideal either. On Linux it...
As far as i know the issue is that both the C++ and the Fortran standard library are required. When linking with the Fortran compiler, only the Fortran standard library...
> was `vcat` using the wrong length? Are you referring to `col_length` and the change in 60eff16? No, in effect it was used correctly. Basically the helper `stuffcol!` iterates from...
Thanks for the review! Anything left that I can do to help moving this forward?