mistermicheels
mistermicheels
@bitdisaster I think the problem with `exe-icon-extractor` is that package.json for this module now refers to `@bitdisaster/exe-icon-extractor` but the code still refers to just `exe-icon-extractor`. See [GitHub search result](https://github.com/felixrieseberg/electron-wix-msi/search?q=exe-icon-extractor). I...
@layaLils @pichotweb Manually installing `exe-icon-extractor` indeed gets rid of the error, but `exe-icon-extractor` is still a fallback for the case where there is no custom app icon specified in options....
@a7madgamal I was able to get this working in GitHub Actions on `windows-latest` using the following step: `run: echo "::add-path::${env:wix}bin"`. The command is a mix of GitHub Actions-specific syntax and...
@linonetwo this is what worked for me: https://github.com/mistermicheels/current-task/blob/master/.github/workflows/build-for-windows.yml#L19 P.S.: The `windows-latest` image for GitHub Actions [already has WiX Toolset installed](https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md?plain=1#L83), but you still need to add it to the `PATH`...
@linonetwo you still need to install `electron-wix-msi` as a dev dependency for your project. But it cannot run without having WiX Toolset installed and available on the `PATH`. That last...
@linonetwo I just tested my existing GitHub Actions workflow with `windows-2022` and it still works, including the use of `npm` after I set the path variable. See here: https://github.com/mistermicheels/current-task/runs/5805767280?check_suite_focus=true The...
@kakyoism Forge actually doesn't change anything about the property's name. The problem is that `electron-wix-msi` documentation specifies `iconPath` but its code requires `appIconPath`. I mentioned this in felixrieseberg/electron-wix-msi#99 but seems...
> This appears to just be a documentation issue I marked this as a bug because 6.0.0-beta.52 automatically took care of this (based on the icon from `packagerConfig`) and 6.0.0-beta.53...
Hi @gillyspy, thanks for yet another suggestion for improvement! What I could do is implement a new flag called `includeUpwardNavigation` that adds "Go one level up" and "Go to top...
@gillyspy as you said "no rush", I'm assuming it's fine for you if I can tackle this one within a few weeks? Can you wait that long for me to...