missing-user

Respect prob.bounds in all solver wrappers

8

Only the constrained_solve overloads respected the problem bounds, the least_squares_solve overloads ignored them, unless passed with `bounds=prob.bounds` explicitly. This is unintuitive, since these functions are specifically overloads for `LeastSquaresProblem`, so...

SurfaceRZFourier cache isn't invalidated by setting rc, zs, rs, zc arrays

2

There are not setter properties for the arrays `rc`, `zs`, `rs`, `zc`, so `recompute_bell()` is not triggered by overwriting them (there is of course setter properties for individual elements tho)....

Fix logical errors and typos in Spec equilibrium object

4

There were a few bugs in the Spec equilibrium object that I spotted: - Many error checks were written, but the `raise` clause was omitted, so they didn't take effect...

Since users will probably be running the script with similar parameters over and over again, I'd suggest adding optional client side caching to the QUASR_loader method to not overload the...

Grid virtual casing

6

Addressing issue https://github.com/PrincetonUniversity/SPEC/issues/32 with a faster virtual casing implementation. I iteratively increase the resolution to get an estimate of how well the integral has converged, and could adaptively refine the...

py_spec minor bugfix

1

`None` checks should be done with is None in python, instead of `== None` to avoid issues with equality overloads. Passing an RGB color (np.array) to to the plotting functions...

Missing compilation flags using spec_wrapper

1

I noticed, that SPEC was significantly slower when running from simsopt than standalone. Looking closer, the shared object Library produced when compiling `spec_wrapper` doesn't utilize the same compilation flags, e....