minux comments

Results 331 comments of


                                            minux

Add a gRPC example for tutorial

Thanks a lot, @ikhoon! 😃

Fix to override HTTP/2 graceful shutdown timeout correctly

Thanks for reviewing. 😉

Add support for alternative protobuf content types

> should I do it? I'd have to pass the request acceptheaders to deframeAndRespond, then set response contentType to that included in acceptHeader if the request contentType isn't in it....

Add support for alternative protobuf content types

Our new hero, @j-min5u! 😆 What's your next PR? 😆

Add support for alternative protobuf content types

Please, don't worry. 😄 Take care of yourself and see you later. 😄

Add WebSocketService

I think this is ready for review. 😉

Add WebSocketService

@ikhoon All fixed. PTAL. 😉

Change the insertion order of `ExceptionHandlerFunction`

> I thought this was an intended behavior. Yeah, that was the intention but as described it has problems. > ExceptionHandlerFunction was supposed to always be applied at the same...

Change the insertion order of `ExceptionHandlerFunction`

Let me change the label to discussion because others might have different points of view. 🤔 cc @trustin, @ikhoon and @jrhee17

Change the insertion order of `ExceptionHandlerFunction`

> should we move the Thrift error handler into ThriftCallService? That's a good point. +1 for moving it.