Minwoo Im

Results 13 comments of Minwoo Im

@MatiasBjorling, > liblightnvm is often used to make it easy to use OCSSDs from user-space. Its cli tools allow easy translation from a generic address to the addresses of different...

@safl , > Hi Minwoo Im, Thanks for your interest. I am currently on vacation but let me get back to you during next week. Best, Simon søn. I hope...

> For the second patch, it looks like what's happening is that fio issues a write, followed by a sync, then a read, then (since `last_was_sync` is false) another sync....

@vincentkfu , I've added a test case to test whether FLUSH commands are issued properly or not. Please review.

> For the `io_u: ensure fsync only after write(s)` patch can you split it into two patches? One with the rename `last_ddir` to `last_ddir_completed`, and one with the bug fix....

@vincentkfu , Applied review comments, Thanks for your time.

How about the fix below? looks like missing to clear `inflight_issued` ```diff diff --git a/libfio.c b/libfio.c index 57f3f858dcfc..4726fa1e5e7b 100644 --- a/libfio.c +++ b/libfio.c @@ -161,6 +161,7 @@ void reset_all_stats(struct thread_data...

> Wow I happened to be looking at this via #1970 just yesterday. My concern is that this isn't going to work for jobs where the initial job was somehow...

> Ah good point but I still think the jobs I posted will fail with your PR... @sitsofe , Do you mean verify failure? I ran your script and offset=0x0,...