Ming-jun Lu

Results 19 comments of Ming-jun Lu

Hi, thanks for your great efforts! I would like to help improve the translation of Traditional Chinese (zh-Hant). > Good question, for now please make PRs to this repo. Eventually...

@neyb Really need some help here 🙏

I can help with traditional Chinese translation as well 🙂

> Going by what I can find online, it sounds like both "zh-TW" and "zh-HK" are for traditional Chinese. Correct! Traditional Chinese characters are used in both Hong Kong and...

I'm not familiar with localization, but it seems a little bit cumbersome to translate values like `weapon.type` and `armor.type`.

@LartTyler Thanks for your great work! > Since missing strings will show up as blanks in the contribution site, I'd suggest navigating the site in English, like normal, opening up...

> As far as the defaulting to English for missing values, do you think that makes sense only in the context of the contrib site? Or do you think that...

@dearamerican @melamber Inspired by the snippet in [this comment](https://github.com/mapbox/mapbox-gl-language/issues/31#issuecomment-510307581), here's how I changed the labels into Traditional Chinese. ```jsx import React from 'react'; import ReactMapboxGl from 'react-mapbox-gl'; const AwesomeMap =...

@nataliahering No problem! I'm glad it helped 😄

I'm also wondering which emoji to use for adding a rate limit 🤔