milkcask

Results 9 comments of milkcask

Let's assume we add 2 props: `dismissOnClickOutside` and `dismissOnEsc`. We could simply add an OR in `onEscape` and `onBackdropClick`. And I think `closeable: false` should override `dismissOnClickOutside: true` and `dismissOnEsc:...

I came across this discussion in Svelte some time ago: https://github.com/sveltejs/kit/issues/1997. I can share some background info. There are many behaviour differences between interfaces and type literals in Typescript and...

@gdorsi Your snippet lgtm and should work. What is tsc complaining about on your end? I usually use this to avoid unnecessary recursion: ```ts type InferIndexSignature = { [K in...

I think the homomorphic version of Typify / InferIndexSignature can be adjusted so that it extends (or intersects) `JsonValue`. ```ts type TypifiedJsonValue = { [K in keyof T & string]:...

@gdorsi That's one of the many undocumented uses of typescript and was added because Immutable.js needed it. See https://github.com/Microsoft/TypeScript/issues/25379. As seen in that issue, it can be combined with recursion...

Last known good: [4.3.0-dev.20210319](https://www.npmjs.com/package/typescript/v/4.3.0-dev.20210319) Doesn't work since: [4.3.0-dev.20210322](https://www.npmjs.com/package/typescript/v/4.3.0-dev.20210322) Related https://github.com/microsoft/TypeScript/pull/43183

Some progress note. I can confirm the change in https://github.com/microsoft/TypeScript/pull/43183 was the root cause. `checkIdentifier` is called with `CheckMode.TypeOnly` to get the type of second antecedent Consider: ```ts while (currentParent)...

It seems we can't bring back the behaviour before #43183. I'm thinking we might need to keep track of what the blocks/flows do with CheckMode. (Or perhaps a new flag?)...

I’m unsure about how the implementation should work. Should it clone the nodes, or just the weights?