Martin Redington

icon company Hudl icon location London

Results 121 comments of Martin Redington

balanced_xctest_lifecycle, single_test_class, empty_xctest_method and test_case_accessibility do not work on when the parent class is a subclass of XCTestCase

Looking at https://github.com/realm/SwiftLint/blob/main/Source/SwiftLintFramework/Rules/Lint/BalancedXCTestLifecycleRule.swift it looks like the code is checking that the class being linted does inherit from XCTestCase, even indirectly, here ``` private func testClasses(in file: SwiftLintFile) -> [SourceKittenDictionary]...

balanced_xctest_lifecycle, single_test_class, empty_xctest_method and test_case_accessibility do not work on when the parent class is a subclass of XCTestCase

So I just had a go at adding an `xctestcase_subclasses` option to `test_case_accessibility`, which seemed pretty easy as it already has a configuration, and I got it working on the...

balanced_xctest_lifecycle, single_test_class, empty_xctest_method and test_case_accessibility do not work on when the parent class is a subclass of XCTestCase

> > Do you call SwiftLint in its own build phase like explained [here](https://github.com/realm/SwiftLint#xcode)? That should actually work fine even with a manually compiled SwiftLint binary. yep, although mine looks...

Add `test_parent_classes` option to `single_test_class`, `balanced_xctest_lifecycle`, and `empty_xctest` rules

Replaced by #4262

AWSSigner processURL does not handle query parameters with no equal sign or value correctly

https://github.com/soto-project/soto-core/pull/524

Rule Request: [explicit_init] - avoid using `let cl: Class = .init()`

I have actually implemented this rule. I don't think I kept my branches (I built it as a demo), but it was very easy, at least to catch all `.init`...

Rule Request: [explicit_init] - avoid using `let cl: Class = .init()`

Work in progress ^^^^

Implement baseline functionality

I'm interested in picking this up. Not sure when I'll have time, or if I'll start from here, or from scratch right now. > Looking at this again for the...

Implement baseline functionality

So I have a very basic implementation at #5475 Seems to work for my basic test case, but will try to work on it and to add some more docs...

Xcode 14 introduces new run script build phase warning for SwiftLint

> I'm seriously considering removing the SwiftLint build phase entirely until this is fixed. I can run it manually as needed, and keep it in the CI/CD flow. This is...